From: Herbert Xu Subject: Re: [PATCH v2] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE Date: Tue, 31 May 2011 15:22:45 +1000 Message-ID: <20110531052245.GA17068@gondor.apana.org.au> References: <1306379477-24552-1-git-send-email-msb@chromium.org> <20110525.233411.1372538972166578285.davem@davemloft.net> <20110526232058.GQ11023@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Joe Perches To: Mandeep Singh Baines Return-path: Received: from helcar.apana.org.au ([209.40.204.226]:46973 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066Ab1EaFWz (ORCPT ); Tue, 31 May 2011 01:22:55 -0400 Content-Disposition: inline In-Reply-To: <20110526232058.GQ11023@google.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, May 26, 2011 at 04:20:58PM -0700, Mandeep Singh Baines wrote: > David Miller (davem@davemloft.net) wrote: > > > > The temp[] buffer is explicitly places inside the inner most > > basic block so that the compiler doesn't allocate the stack > > space unless that code path is taken. > > > > Fixed in V2 (this patch). Thanks for the review. > > -- >8 -- (snip) > > Plus some other minor cleanup. I don't really like the cleanups. In any case, mixing up the use of SHA1_BLOCK_SIZE with cleanups increases the chance of introducing a bug. So please redo the patch with only the addition of SHA1_BLOCK_SIZE and nothing else. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt