From: Linus Torvalds Subject: Re: [PATCH] lib/sha1: use the git implementation of SHA-1 Date: Sun, 7 Aug 2011 09:52:38 -0700 Message-ID: References: <1312595187-3265-1-git-send-email-msb@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Mandeep Singh Baines , linux-kernel@vger.kernel.org, Ramsay Jones , Nicolas Pitre , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux@arm.linux.org.uk To: Joachim Eastwood Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:57521 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638Ab1HGQxD (ORCPT ); Sun, 7 Aug 2011 12:53:03 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sun, Aug 7, 2011 at 4:54 AM, Joachim Eastwood wrote: > > I see some ARM asm in your patch, maybe this is the cause? No, it's just a barrier to make sure the compiler doesn't do crazy things, no actual asm instructions involved. That code is quite well tested in git, so I'm surprised it has any problems on arm. It also has zero loops, a hang sounds odd. Can you get some more debug information out of it (for example, where it hangs - maybe "initcall_debug=1" on the kernel command line? The biggest difference with the git sources is the slightly different calling conventions (passing the workspace array as an argument is bad for code generation, btw - since now gcc doesn't see that the workspace accesses are dead) and the fact that the kernel version uses kernel macros like "get_unaligned_be32()" rather than it's own implementation. Linus