From: Linus Torvalds Subject: Re: [PATCH] lib/sha1: use the git implementation of SHA-1 Date: Sun, 7 Aug 2011 14:06:51 -0700 Message-ID: References: <1312595187-3265-1-git-send-email-msb@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Andreas Schwab , Nicolas Pitre , Mandeep Singh Baines , linux-kernel@vger.kernel.org, Ramsay Jones , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux@arm.linux.org.uk To: Joachim Eastwood Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:58340 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755117Ab1HGVHP (ORCPT ); Sun, 7 Aug 2011 17:07:15 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sun, Aug 7, 2011 at 1:48 PM, Joachim Eastwood wrote: > > yes, this works. At least my board boots as normal. Ok, I'll remove it for -rc1, just to have a working ARM setup. Maybe we can re-introduce it later (either together with some arm-specific hack for SHA_WORKSPACE_WORDS or by having an arm-optimized version of the *good* sha1 routine). But I doubt it: there used to be an ARM-optimized thing in git too. It was removed two years ago with the commit message: remove ARM and Mozilla SHA1 implementations They are both slower than the new BLK_SHA1 implementation, so it is pointless to keep them around. and quite frankly, that removed code seems to be the same as the in-kernel one. So I bet the ARM "optimized" SHA1 is simply not worth keeping around. Linus