From: Steffen Klassert Subject: Re: [PATCH v3 04/17] crypto: Add userspace configuration API Date: Fri, 23 Sep 2011 10:37:06 +0200 Message-ID: <20110923083706.GA4725@secunet.com> References: <20110921085855.GE1808@secunet.com> <20110921090238.GI1808@secunet.com> <20110923055554.GA15901@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from a.mx.secunet.com ([195.81.216.161]:43218 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959Ab1IWIhJ (ORCPT ); Fri, 23 Sep 2011 04:37:09 -0400 Content-Disposition: inline In-Reply-To: <20110923055554.GA15901@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Sep 23, 2011 at 03:55:54PM +1000, Herbert Xu wrote: > On Wed, Sep 21, 2011 at 11:02:38AM +0200, Steffen Klassert wrote: > > > > +/* Netlink message attributes. */ > > +enum crypto_attr_type_t { > > + CRYPTOCFGA_UNSPEC, > > + CRYPTOCFGA_PRIORITY_VAL, /* __u32 */ > > + __CRYPTOCFGA_MAX > > + > > +#define CRYPTOCFGA_MAX (__CRYPTOCFGA_MAX - 1) > > +}; > > + > > +struct crypto_user_alg { > > + char cru_name[CRYPTO_MAX_ALG_NAME]; > > + char cru_driver_name[CRYPTO_MAX_ALG_NAME]; > > + char cru_module_name[CRYPTO_MAX_ALG_NAME]; > > + __u32 cru_type; > > + __u32 cru_mask; > > + __u32 cru_priority; > > Do we still need this since you already have the priority as > an attribute? > Actually no, I'll remove it. Anything else to change? If not I'll update the patches and resend.