From: Herbert Xu Subject: Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm Date: Mon, 3 Oct 2011 21:35:13 +0100 Message-ID: <20111003203513.GA10346@gondor.apana.org.au> References: <20110930192956.4176.29905.stgit@elm3c44.beaverton.ibm.com> <20111003153634.GA12447@tux1.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: djwong@us.ibm.com, Andreas Dilger , Mingming Cao , David Miller , linux-crypto , linux-ext4@vger.kernel.org, linux-fsdevel , linux-kernel , Bob Pearson , Theodore Tso To: Joakim Tjernlund Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Oct 03, 2011 at 10:27:03PM +0200, Joakim Tjernlund wrote: > > > > Start from Bobs latest patches and add crc32c to lib/crc32.c > > > > If I did that, how should I handle patching in the hardware accelerated version > > on Intel systems? That switcheroo ability seems to have been Herbert Xu's > > motivation for moving crc32c into crypto/ in the first place: > > I don't know, I haven't looked at that problem. I suspect it moved because that > was the easiest solution. Having an identical impl. of crc32(only the table values differ) > in crypto compared to the one in lib is not the way forward though. You can always get crypto/crc32c.c to use call helpers from lib/crc32.c. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt