From: Herbert Xu Subject: Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm Date: Tue, 4 Oct 2011 07:59:53 +0100 Message-ID: <20111004065953.GA16606@gondor.apana.org.au> References: <20110930192956.4176.29905.stgit@elm3c44.beaverton.ibm.com> <20111003153634.GA12447@tux1.beaverton.ibm.com> <20111003203513.GA10346@gondor.apana.org.au> <20111004005510.GB12447@tux1.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Joakim Tjernlund , Andreas Dilger , Mingming Cao , David Miller , linux-crypto , linux-ext4@vger.kernel.org, linux-fsdevel , linux-kernel , Bob Pearson , Theodore Tso To: "Darrick J. Wong" Return-path: Content-Disposition: inline In-Reply-To: <20111004005510.GB12447@tux1.beaverton.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote: > > So what I think I'm hearing is... > > 1. Apply Bob's slice-by-8 algorithm patch to regular crc32. > 2. Adapt crc32's build code to generate crc32c as well. > 3. Remove crypto/crc32c.c's implementation and have it wrap the code generated > by #2. > 4. Retain the current libcrc32c. I guess if you don't configure CRYPTO and > CRYPTO_CRC32C then it could also just reference the generated crc32c functions > directly. > > Is this a satisfactory way to move forward? All good except that you don't really have to touch libcrc32c at all. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt