From: Greg KH Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1) Date: Mon, 17 Oct 2011 09:22:08 -0700 Message-ID: <20111017162208.GA6661@kroah.com> References: <92d93a9fe52e048a21d19732c31d80c9ec44de77.1318598705.git.dmitry.kasatkin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Morris , linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com, dhowells@redhat.com, herbert@gondor.hengli.com.au To: "Kasatkin, Dmitry" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Oct 17, 2011 at 12:11:37PM +0300, Kasatkin, Dmitry wrote: > >From Kernel Docbook > > Similar to EXPORT_SYMBOL() except that the > symbols exported by EXPORT_SYMBOL_GPL() can > only be seen by modules with a > MODULE_LICENSE() that specifies a GPL > compatible license. It implies that the function is considered > an internal implementation issue, and not really an interface. > > "not really an interface".... > > Should it really be EXPORT_SYMBOL_GPL? Yes.