From: "Darrick J. Wong" Subject: Re: [PATCH 14/14] crc32: Select an algorithm via kconfig Date: Fri, 2 Dec 2011 18:36:46 -0800 Message-ID: <20111203023646.GB16577@tux1.beaverton.ibm.com> References: <20111201201341.5876.83743.stgit@elm3c44.beaverton.ibm.com> <20111201201517.5876.39207.stgit@elm3c44.beaverton.ibm.com> <20111202002505.GB19842@gondor.apana.org.au> Reply-To: djwong@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Theodore Tso , Joakim Tjernlund , Bob Pearson , linux-kernel , Andreas Dilger , linux-crypto , linux-fsdevel , Mingming Cao , linux-ext4@vger.kernel.org To: Herbert Xu Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:33798 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275Ab1LCCg7 (ORCPT ); Fri, 2 Dec 2011 21:36:59 -0500 Received: from /spool/local by e4.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Dec 2011 21:36:58 -0500 Content-Disposition: inline In-Reply-To: <20111202002505.GB19842@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Dec 02, 2011 at 08:25:05AM +0800, Herbert Xu wrote: > On Thu, Dec 01, 2011 at 12:15:17PM -0800, Darrick J. Wong wrote: > > Allow the kernel builder to choose a crc32* algorithm for the kernel. > > > > Signed-off-by: Darrick J. Wong > > I don't like this at all. How do you expect distros or indeed > anyone to make this choice? For generic C implementations like > this we should only have one, and not many. Slice-by-8 should be picked automatically if the builder doesn't explicitly pick another one. The other choices are provided for people who want a slimmer cache footprint. I guess I could make the Kconfig file a bit more explicit about slice-by-8 being default, or I guess we could just ignore this one patch and thereby keeping us with the old method where anyone who wants the slimmer implementations patches the #defines. --D > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >