From: Joe Perches Subject: drivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion Date: Mon, 12 Dec 2011 15:55:23 -0800 Message-ID: <1323734123.3837.2.camel@joe2Laptop> References: <4EE688FC.8090606@gmail.com> <1323733493.1812.10.camel@joe2Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , LKML , linux-crypto To: roel , Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:33883 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753426Ab1LLXz0 (ORCPT ); Mon, 12 Dec 2011 18:55:26 -0500 In-Reply-To: <1323733493.1812.10.camel@joe2Laptop> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > The test not [val1] or not [val2] always evaluates to true Hello Looking at drivers with: $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width) { drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width) Most likely these tests should be: if (mf->height != tfmt->height || mf->width != tfmt->width)