From: "David Laight" Subject: RE: [PATCH 2/3] sha512: reduce stack usage to safe number Date: Mon, 16 Jan 2012 11:37:34 -0000 Message-ID: References: <1326709382.2255.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "Alexey Dobriyan" , "Linus Torvalds" , "Herbert Xu" , , , , "Steffen Klassert" , To: "Eric Dumazet" Return-path: Received: from mx0.aculab.com ([213.249.233.131]:42259 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754285Ab2APLhf convert rfc822-to-8bit (ORCPT ); Mon, 16 Jan 2012 06:37:35 -0500 Received: from mx0.aculab.com ([127.0.0.1]) by localhost (mx0.aculab.com [127.0.0.1]) (amavisd-new, port 10024) with SMTP id 04865-10 for ; Mon, 16 Jan 2012 11:37:32 +0000 (GMT) Content-class: urn:content-classes:message In-Reply-To: <1326709382.2255.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Sender: linux-crypto-owner@vger.kernel.org List-ID: > By the way, I suspect previous code was chosen years ago because this > version uses less stack but adds much more code bloat. > > size crypto/sha512_generic.o crypto/sha512_generic_old.o > text data bss dec hex filename > 17369 704 0 18073 4699 crypto/sha512_generic.o > 8249 704 0 8953 22f9 > crypto/sha512_generic_old.o I wonder what the difference in execution times is? I know this is very dependant in the actual cpu and the cold/warm cache state... But some measurements might be useful. David