From: Herbert Xu Subject: Re: [PATCH] crypto: aesni-intel - fix unaligned cbc decrypt for x86-32 Date: Thu, 31 May 2012 15:27:54 +1000 Message-ID: <20120531052754.GA17273@gondor.apana.org.au> References: <1338334988-20025-1-git-send-email-minipli@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Daniel , linux-crypto@vger.kernel.org To: Mathias Krause Return-path: Received: from sting.hengli.com.au ([178.18.18.71]:58773 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751855Ab2EaF2D (ORCPT ); Thu, 31 May 2012 01:28:03 -0400 Content-Disposition: inline In-Reply-To: <1338334988-20025-1-git-send-email-minipli@googlemail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, May 30, 2012 at 01:43:08AM +0200, Mathias Krause wrote: > The 32 bit variant of cbc(aes) decrypt is using instructions requiring > 128 bit aligned memory locations but fails to ensure this constraint in > the code. Fix this by loading the data into intermediate registers with > load unaligned instructions. > > This fixes reported general protection faults related to aesni. > > References: https://bugzilla.kernel.org/show_bug.cgi?id=43223 > Reported-by: Daniel > Cc: stable@kernel.org [v2.6.39+] > Signed-off-by: Mathias Krause Have measured this against increasing alignmask to 15? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt