From: Eric =?ISO-8859-1?B?QuluYXJk?= Subject: Re: [PATCH 2/5] crypto: add Atmel AES driver Date: Fri, 6 Jul 2012 15:25:21 +0200 Message-ID: <20120706152521.5145f1aa@eb-e6520> References: <1341163187-14946-1-git-send-email-eric@eukrea.com> <1341163187-14946-3-git-send-email-eric@eukrea.com> <20120706121719.GD4450@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, nicolas@eukrea.com To: Jean-Christophe PLAGNIOL-VILLARD Return-path: Received: from smtpfb1-g21.free.fr ([212.27.42.9]:53720 "EHLO smtpfb1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756016Ab2GFN0Y convert rfc822-to-8bit (ORCPT ); Fri, 6 Jul 2012 09:26:24 -0400 In-Reply-To: <20120706121719.GD4450@game.jcrosoft.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Jean-Christophe, Le Fri, 6 Jul 2012 14:17:19 +0200, Jean-Christophe PLAGNIOL-VILLARD a =E9crit : > > + u8 buf_in[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32)); > can you allocate it > > + int dma_in; > > + struct atmel_aes_dma dma_lch_in; > > + > > + u8 buf_out[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32)); > ditto >=20 Why is that preferred to allocate dynamicaly these buffers (we are talking of 2 x 16 bytes buffers) ? > otherwise looks good >=20 thanks Eric