From: Liu Qiang-B32616 Subject: RE: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self test interface Date: Tue, 31 Jul 2012 02:47:26 +0000 Message-ID: References: <1343380616-12126-1-git-send-email-qiang.liu@freescale.com> <5016C8F9.7070801@freescale.com> <20120730183322.GA32504@ovro.caltech.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-crypto@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Vinod Koul , "herbert@gondor.hengli.com.au" , Dan Williams , Li Yang-R58472 , "davem@davemloft.net" To: "Ira W. Snyder" , Tabi Timur-B04825 Return-path: Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14]:57926 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847Ab2GaCrb convert rfc822-to-8bit (ORCPT ); Mon, 30 Jul 2012 22:47:31 -0400 In-Reply-To: <20120730183322.GA32504@ovro.caltech.edu> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: > -----Original Message----- > From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto- > owner@vger.kernel.org] On Behalf Of Ira W. Snyder > Sent: Tuesday, July 31, 2012 2:33 AM > To: Tabi Timur-B04825 > Cc: Liu Qiang-B32616; linux-crypto@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; Vinod Koul; herbert@gondor.hengli.com.au; Dan > Williams; Li Yang-R58472; davem@davemloft.net > Subject: Re: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self > test interface > > On Mon, Jul 30, 2012 at 12:48:41PM -0500, Timur Tabi wrote: > > qiang.liu@freescale.com wrote: > > > > > > Add memory copy self test when probe device, fsl-dma will be disabled > > > if self test failed. > > > > Is this a real problem that can occur? The DMA driver used to have a > > self-test, but I removed it a long time ago because it was pointless. > I > > don't see why we need to add another one back in. > > > > -- > > Timur Tabi > > Linux kernel developer at Freescale > > > > I made a comment that a test suite for the async_tx API would be very > helpful in diagnosing similar problems in this and other DMA drivers. > Something standalone, similar to the drivers/dma/dmatest.c driver, using > the async_tx API. > > I think this was misinterpreted into me asking that the driver have a > built-in self test. I will drop it in next version. Thanks. > > Ira > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html