From: Geanta Neag Horia Ioan-B05471 Subject: RE: [PATCH 5/5] crypto: talitos - add IPsec ESN support Date: Tue, 7 Aug 2012 06:54:14 +0000 Message-ID: References: <1343917001-20001-1-git-send-email-horia.geanta@freescale.com> <1343917001-20001-5-git-send-email-horia.geanta@freescale.com> <20120806204751.1f6277ba8f7b1de92fd128ac@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-crypto@vger.kernel.org" , Herbert Xu , "David S. Miller" To: Phillips Kim-R1AAHA Return-path: Received: from [216.32.181.183] ([216.32.181.183]:3194 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751572Ab2HGGzY convert rfc822-to-8bit (ORCPT ); Tue, 7 Aug 2012 02:55:24 -0400 In-Reply-To: <20120806204751.1f6277ba8f7b1de92fd128ac@freescale.com> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, 7 Aug 2012 04:47:51 +0300, Phillips Kim-R1AAHA wrote: > On Thu, 2 Aug 2012 17:16:41 +0300 > Horia Geanta wrote: > >> + .cra_name = "authencesn(hmac(sha1),cbc(aes))", >> + .cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos", > > the driver name should be authencesn, too, no? Oops, typo. Thanks for spotting it. > > Also: if the algorithm name is really all that changes, can it be > done more space-efficiently with some string manipulation in the > algorithm registration loop?: If registering an "authenc" > algorithm, also register an "authencesn" version. Agree. Will come up with smth more elegant in v2. > > The rest of the patchseries looks fine. Thanks for reviewing. > > Thanks, > > Kim