From: Dan Williams Subject: Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance Date: Wed, 29 Aug 2012 07:52:55 -0700 Message-ID: <1346251975.27020.2.camel@localhost.localdomain> References: <1344500375-8457-1-git-send-email-qiang.liu@freescale.com> <20120809170307.GG14264@ovro.caltech.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "vinod.koul@intel.com" , "arnd@arndb.de" , "herbert@gondor.apana.org.au" , "gregkh@linuxfoundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "Ira W. Snyder" To: Liu Qiang-B32616 Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:50146 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644Ab2H2OxS (ORCPT ); Wed, 29 Aug 2012 10:53:18 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, 2012-08-29 at 11:15 +0000, Liu Qiang-B32616 wrote: > Hi Dan, > > Ping? > Can you apply these patches? Thanks. > I'm working my way through them. The first thing I notice is that xor_chan->desc_lock is taken inconsistently. I.e. spin_lock_irqsave() in talitos_process_pending() and spin_lock_bh() everywhere else. Have you run these patches with lockdep? -- Dan