From: Herbert Xu Subject: Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7 Date: Thu, 27 Sep 2012 02:22:46 -0700 Message-ID: <20120927092246.GA23846@gondor.apana.org.au> References: <1348080820-22250-1-git-send-email-horia.geanta@freescale.com> <20120927052539.GA22160@gondor.apana.org.au> <506407EE.50406@freescale.com> <20120927081425.GB23122@gondor.apana.org.au> <50641167.9010308@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, "David S. Miller" , Kim Phillips To: Horia Geanta Return-path: Received: from sting.hengli.com.au ([178.18.18.71]:45036 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754306Ab2I0JWu (ORCPT ); Thu, 27 Sep 2012 05:22:50 -0400 Content-Disposition: inline In-Reply-To: <50641167.9010308@freescale.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Sep 27, 2012 at 11:42:15AM +0300, Horia Geanta wrote: > On 9/27/2012 11:14 AM, Herbert Xu wrote: > >On Thu, Sep 27, 2012 at 11:01:50AM +0300, Horia Geanta wrote: > >> > >>Again, this patch (e46e9a) is not the culprit, it merely exposes the > >>deficiencies in the talitos driver. > >>AFAICT, these cases (zero assoc data, noncontiguous iv and assoc > >>data) have never been handled correctly in the driver. > > > >OK, without the patches does the driver crash the self-test or > >merely fail the self-test? > > It fails. > Crash occurs when setting the fips=1 boot param. OK, in that case I think we can just leave it as it is. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt