From: Herbert Xu Subject: Re: [PATCH] crypto: tegra-aes - fix error-valued pointer dereference Date: Fri, 9 Nov 2012 17:34:18 +0800 Message-ID: <20121109093418.GA25720@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, grant.likely@secretlab.ca, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, linux-crypto@vger.kernel.org, devicetree-discuss@lists.ozlabs.org To: Wei Yongjun Return-path: Received: from sting.hengli.com.au ([178.18.18.71]:35590 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750976Ab2KIJee (ORCPT ); Fri, 9 Nov 2012 04:34:34 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Oct 25, 2012 at 10:55:04PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > clk_put(dd->aes_clk) will dereference an error-valued pointer since the > dd->aes_clk is a ERR_PTR() value. The correct check is call clk_put() > if !IS_ERR(dd->aes_clk). > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt