From: Lai Jiangshan Subject: Re: [PATCH 01/10] workqueue: add wq_numa_tbl_len and wq_numa_possible_cpumask[] Date: Thu, 21 Mar 2013 00:43:08 +0800 Message-ID: References: <1363737629-16745-1-git-send-email-tj@kernel.org> <1363737629-16745-2-git-send-email-tj@kernel.org> <20130320154814.GY3042@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: laijs@cn.fujitsu.com, axboe@kernel.dk, jack@suse.cz, fengguang.wu@intel.com, jmoyer@redhat.com, zab@redhat.com, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org To: Tejun Heo Return-path: Received: from mail-ie0-f178.google.com ([209.85.223.178]:34565 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933184Ab3CTQnI (ORCPT ); Wed, 20 Mar 2013 12:43:08 -0400 In-Reply-To: <20130320154814.GY3042@htj.dyndns.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Mar 20, 2013 at 11:48 PM, Tejun Heo wrote: > On Wed, Mar 20, 2013 at 11:43:30PM +0800, Lai Jiangshan wrote: >> > + for_each_node(node) >> > + BUG_ON(!alloc_cpumask_var_node(&wq_numa_possible_cpumask[node], >> > + GFP_KERNEL, node)); >> > + for_each_possible_cpu(cpu) { >> > + node = cpu_to_node(cpu); >> > + if (WARN_ON(node == NUMA_NO_NODE)) { >> > + pr_err("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu); >> >> since you used WARN_ON(), not BUG_ON(), I think you need to free >> allocated memory here. > > I don't know. Is it necessary? It shouldn't happen sans bugs in arch > code and we're vomiting warning message with full stack trace. The > system will function but something is seriously screwed. I don't > think it matters whether we free the puny number of bytes there or > not and I don't wanna nest deeper there. :P I agree with you, but many people use semantic analysis tools to do hunting in the kernel. they may interrupt you again. > > -- > tejun