From: Linus Walleij Subject: Re: [PATCH 4/9 v2] crypto: ux500/cryp - Prepare clock before enabling it Date: Thu, 25 Apr 2013 13:57:50 +0200 Message-ID: References: <1366280825-31136-1-git-send-email-lee.jones@linaro.org> <1366280825-31136-5-git-send-email-lee.jones@linaro.org> <20130419122226.GB3432@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Herbert Xu , "David S. Miller" , Andreas Westin , "linux-crypto@vger.kernel.org" To: Lee Jones Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:64660 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757169Ab3DYL5v (ORCPT ); Thu, 25 Apr 2013 07:57:51 -0400 Received: by mail-ie0-f174.google.com with SMTP id 10so3371047ied.19 for ; Thu, 25 Apr 2013 04:57:51 -0700 (PDT) In-Reply-To: <20130419122226.GB3432@gmail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Apr 19, 2013 at 2:22 PM, Lee Jones wrote: > Slight change of plan for v2. > > Now we're doing a seperate clk_prepare(), as the clk_enable() in the > previous patch turned out to be called inside a spin_lock(). > > Arnd, can you confirm your Ack please? > > ---- > > crypto: ux500/cryp - Prepare clock before enabling it > > If we fail to prepare the ux500-cryp clock before enabling it the > platform will fail to boot. Here we insure this happens. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Same formatting problems as the other prepare/enable patch. Include Ulf Hansson. (Apart from this it looks OK.) Yours, Linus Walleij