From: Russell King - ARM Linux Subject: Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() Date: Fri, 26 Apr 2013 10:44:30 +0100 Message-ID: <20130426094430.GH14496@n2100.arm.linux.org.uk> References: <1366280825-31136-1-git-send-email-lee.jones@linaro.org> <20130426081646.GD24632@intel.com> <1457204.tIrKjcEogd@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-arm-kernel@lists.infradead.org, Vinod Koul , Linus Walleij , Linus WALLEIJ , "linux-kernel@vger.kernel.org" , magnus.p.persson@stericsson.com, Herbert Xu , "linux-crypto@vger.kernel.org" , Andreas Westin , Lee Jones , "David S. Miller" To: Arnd Bergmann Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:39179 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932682Ab3DZJow (ORCPT ); Fri, 26 Apr 2013 05:44:52 -0400 Content-Disposition: inline In-Reply-To: <1457204.tIrKjcEogd@wuerfel> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Apr 26, 2013 at 11:39:20AM +0200, Arnd Bergmann wrote: > On Friday 26 April 2013 13:46:46 Vinod Koul wrote: > > > > The mapping & unmapping of dma buffer (memcpy and memory buffer in this txn) is > > required to be performed by the client driver. The dmanegine or dmaengine driver > > will not do that for you... > > I've been wondering about this part: since we need to pass the 'struct device' of > the dma engine (rather than the slave) into dma_map_single, what is the official > way to do that? Should the slave driver just rely on dma_chan->device->dev to > work correctly for the purpose of dma-mapping.h interfaces? Yes.