From: Tim Chen Subject: Re: linux-next: Tree for May 15 (crypto /crct10dif) Date: Thu, 16 May 2013 09:59:12 -0700 Message-ID: <1368723552.27102.286.camel@schen9-DESK> References: <20130515132627.817585a3d9fb3a3e502eb586@canb.auug.org.au> <5193CCEC.7070909@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Xiong Zhou , Herbert Xu , Stephen Rothwell , Linux-Next , "linux-kernel@vger.kernel.org" , linux-crypto@vger.kernel.org, Randy Dunlap To: Geert Uytterhoeven Return-path: Received: from mga02.intel.com ([134.134.136.20]:8510 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330Ab3EPQ7M (ORCPT ); Thu, 16 May 2013 12:59:12 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, 2013-05-16 at 09:22 +0200, Geert Uytterhoeven wrote: > On Thu, May 16, 2013 at 5:57 AM, Xiong Zhou wrote: > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig > > @@ -378,6 +378,7 @@ config CRYPTO_CRC32_PCLMUL > > > > config CRYPTO_CRCT10DIF > > tristate "CRCT10DIF algorithm" > > + depends on CRC_T10DIF > > This is a library symbol, so "select CRC_T10DIF"? > > > select CRYPTO_HASH > > help > > CRC T10 Data Integrity Field computation is being cast as > > Gr{oetje,eeting}s, > > Geert > This is the fix I think that will resolve the build issues. The generic crc-t10dif transform depends on the library function crc_t10dif_generic in lib/crc-t10dif.c, so "depends on CRC_T10DIF" for CRYPTO_CRCT10DIF is needed. Now for CRC_T10DIF, we should use select CRYPTO_HASH, so it can try to allocate a T10DIF transform if it is available. If not, it will simply use the crc_t10dif_generic function. Loading the generic t10dif crypto transform is not mandatory for the library function crc_t10dif. Thanks for catching the issues. Tim Signed-off-by: Tim Chen --- diff --git a/crypto/Kconfig b/crypto/Kconfig index d1ca631..015df24 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -379,6 +379,7 @@ config CRYPTO_CRC32_PCLMUL config CRYPTO_CRCT10DIF tristate "CRCT10DIF algorithm" select CRYPTO_HASH + depends on CRC_T10DIF help CRC T10 Data Integrity Field computation is being cast as a crypto transform. This allows for faster crc t10 diff diff --git a/lib/Kconfig b/lib/Kconfig index 0cee056..e6ad2e4 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -63,7 +63,7 @@ config CRC16 config CRC_T10DIF tristate "CRC calculation for the T10 Data Integrity Field" - select CRYPTO_CRCT10DIF + select CRYPTO_HASH help This option is only needed if a module that's not in the kernel tree needs to calculate CRC checks for use with the