From: Akinobu Mita Subject: Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer() Date: Sat, 8 Jun 2013 23:04:18 +0900 Message-ID: References: <1370523178-5437-1-git-send-email-akinobu.mita@gmail.com> <1370523178-5437-2-git-send-email-akinobu.mita@gmail.com> <1370524350.23133.11.camel@intelbox> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: LKML , Andrew Morton , Tejun Heo , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, "James E.J. Bottomley" , Douglas Gilbert , linux-scsi@vger.kernel.org To: imre.deak@intel.com Return-path: Received: from mail-ob0-f169.google.com ([209.85.214.169]:64068 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab3FHOET (ORCPT ); Sat, 8 Jun 2013 10:04:19 -0400 In-Reply-To: <1370524350.23133.11.camel@intelbox> Sender: linux-crypto-owner@vger.kernel.org List-ID: 2013/6/6 Imre Deak : > Looks ok to me, perhaps adding the seek functionality to the mapping > iterator would make things more generic and the mapping iterator more > resemble the page iterator. So we'd have a new sg_miter_start_offset and > call it here something like: > > sg_miter_start_offset(&miter, sgl, nents, sg_flags, skip); I also thought something like this could be a new interface for sg_miter_* API, but I haven't found any places where it can be used yet. That's why I made it a local function and didn't create new interface. But putting good function comment like other sg_miter_* API for new local function is harmless and it helps someone who wants interface like this in the future. So I'll do so in next version.