From: Herbert Xu Subject: Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Date: Fri, 23 Aug 2013 20:47:32 +1000 Message-ID: <20130823104731.GA30865@gondor.apana.org.au> References: <5212E5E4.8010408@asianux.com> <5212E61F.7010602@asianux.com> <20130822051122.GB26773@secunet.com> <5215A134.90607@asianux.com> <20130822060503.GC26773@secunet.com> <5215B319.3020908@asianux.com> <20130823104448.GI26773@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chen Gang , linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" To: Steffen Klassert Return-path: Received: from ringil.hengli.com.au ([178.18.16.133]:57395 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754564Ab3HWKrk (ORCPT ); Fri, 23 Aug 2013 06:47:40 -0400 Content-Disposition: inline In-Reply-To: <20130823104448.GI26773@secunet.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote: > On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote: > > Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to > > CPU_DOWN_PREPARE and CPU_UP_CANCELED. > > > > It will fix 2 bugs: > > > > "not check the return value of __padata_remove_cpu() and __padata_add_cpu()". > > "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED". > > > > > > Signed-off-by: Chen Gang > > This looks ok to me, Herbert can you take this one? Sure. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt