From: Matthew Garrett Subject: Re: [PATCH 10/18] efi: Enable secure boot lockdown automatically when enabled in firmware Date: Sun, 25 Aug 2013 17:26:19 +0100 Message-ID: <20130825162618.GA20297@srcf.ucam.org> References: <1377169317-5959-1-git-send-email-jlee@suse.com> <1377169317-5959-11-git-send-email-jlee@suse.com> <20130825162243.GG5171@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Lee, Chun-Yi" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, opensuse-kernel-stAJ6ESoqRxg9hUCZPvPmw@public.gmane.org, David Howells , "Rafael J. Wysocki" , Len Brown , Josh Boyer , Vojtech Pavlik , Matt Fleming , James Bottomley , Greg KH , JKosina-IBi9RG/b67k@public.gmane.org, Rusty Russell , Herbert Xu , "David S. Miller" , "H. Peter Anvin" , Michal Marek , Gary Lin , Vivek Goyal , Matthew Garrett , "Lee, Chun-Yi" To: Pavel Machek Return-path: Content-Disposition: inline In-Reply-To: <20130825162243.GG5171-tWAi6jLit6GreWDznjuHag@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Sun, Aug 25, 2013 at 06:22:43PM +0200, Pavel Machek wrote: > On Thu 2013-08-22 19:01:49, Lee, Chun-Yi wrote: > > From: Matthew Garrett > > > > The firmware has a set of flags that indicate whether secure boot is enabled > > and enforcing. Use them to indicate whether the kernel should lock itself > > down. We also indicate the machine is in secure boot mode by adding the > > EFI_SECURE_BOOT bit for use with efi_enabled. > > > + status = efi_call_phys5(sys_table->runtime->get_variable, > > + L"SecureBoot", &var_guid, NULL, &datasize, &sb); > > What is this L"..." thing? http://en.wikipedia.org/wiki/C_syntax#Wide_character_strings -- Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org