From: joeyli Subject: Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP Date: Mon, 26 Aug 2013 18:25:31 +0800 Message-ID: <1377512731.27967.34.camel__39330.6279126138$1377512844$gmane$org@linux-s257.site> References: <1377169317-5959-1-git-send-email-jlee@suse.com> <1377169317-5959-4-git-send-email-jlee@suse.com> <20130825160147.GB5171@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, opensuse-kernel@opensuse.org, David Howells , "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Josh Boyer , Vojtech Pavlik , Matt Fleming , James Bottomley , Greg KH , JKosina@suse.com, Rusty Russell , Herbert Xu , "David S. Miller" , "H. Peter Anvin" , Michal Marek , Gary Lin , Vivek Goyal To: Pavel Machek Return-path: Received: from smtp.nue.novell.com ([195.135.221.5]:60054 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755892Ab3HZK04 (ORCPT ); Mon, 26 Aug 2013 06:26:56 -0400 In-Reply-To: <20130825160147.GB5171@amd.pavel.ucw.cz> Sender: linux-crypto-owner@vger.kernel.org List-ID: =E6=96=BC =E6=97=A5=EF=BC=8C2013-08-25 =E6=96=BC 18:01 +0200=EF=BC=8CPa= vel Machek =E6=8F=90=E5=88=B0=EF=BC=9A > On Thu 2013-08-22 19:01:42, Lee, Chun-Yi wrote: > > Due to RSA_I2OSP is not only used by signature verification path bu= t also used > > in signature generation path. So, separate the length checking of o= ctet string > > because it's not for generate 0x00 0x01 leading string when used in= signature > > generation. > >=20 > > Reviewed-by: Jiri Kosina > > Signed-off-by: Lee, Chun-Yi >=20 > > +static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X) > > +{ > > + unsigned x_size; > > + unsigned X_size; > > + u8 *X =3D NULL; >=20 > Is this kernel code or entry into obfuscated C code contest? This is = not funny. >=20 > Pavel The small "x" is the input integer that will transfer to big "X" that i= s a octet sting.=20 Sorry for I direct give variable name to match with spec, maybe I need use big_X or.... Do you have good suggest for the naming? Thanks a lot! Joey Lee