From: Pavel Machek Subject: Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP Date: Mon, 26 Aug 2013 13:27:37 +0200 Message-ID: <20130826112737.GA18300@amd.pavel.ucw.cz> References: <1377169317-5959-1-git-send-email-jlee@suse.com> <1377169317-5959-4-git-send-email-jlee@suse.com> <20130825160147.GB5171@amd.pavel.ucw.cz> <1377512731.27967.34.camel@linux-s257.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, opensuse-kernel-stAJ6ESoqRxg9hUCZPvPmw@public.gmane.org, David Howells , "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Josh Boyer , Vojtech Pavlik , Matt Fleming , James Bottomley , Greg KH , JKosina-IBi9RG/b67k@public.gmane.org, Rusty Russell , Herbert Xu , "David S. Miller" , "H. Peter Anvin" , Michal Marek , Gary Lin , Vivek Goyal To: joeyli Return-path: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: List-Archive: Content-Disposition: inline In-Reply-To: <1377512731.27967.34.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org> List-Id: linux-crypto.vger.kernel.org Hi! > > > Due to RSA_I2OSP is not only used by signature verification path but also used > > > in signature generation path. So, separate the length checking of octet string > > > because it's not for generate 0x00 0x01 leading string when used in signature > > > generation. > > > > > > Reviewed-by: Jiri Kosina > > > Signed-off-by: Lee, Chun-Yi > > > > > +static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X) > > > +{ > > > + unsigned x_size; > > > + unsigned X_size; > > > + u8 *X = NULL; > > > > Is this kernel code or entry into obfuscated C code contest? This is not funny. > > > The small "x" is the input integer that will transfer to big "X" that is > a octet sting. > > Sorry for I direct give variable name to match with spec, maybe I need > use big_X or.... Having variables that differ only in case is confusing. Actually RSA_I2OSP is not a good name for function, either. If it converts x into X, perhaps you can name one input and second output? > Do you have good suggest for the naming? Not really, sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html