From: Stephen Warren Subject: Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc Date: Mon, 09 Sep 2013 10:02:04 -0600 Message-ID: <522DF0FC.5080200@wwwdotorg.org> References: <1378712154-30602-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Herbert Xu , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Neil Horman , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij , Varun Wadekar Return-path: In-Reply-To: <1378712154-30602-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On 09/09/2013 01:35 AM, Linus Walleij wrote: > The way I read the Tegra AES RNG is that it has a homebrew > algorithm for initializing the 128bit RNG using timespec and > the unique chip ID. This looks like reinventing the (square) > wheel, instead just grab 128bits from the kernel entropy pool > where the time and (after another patch) chip unique ID is > already mixed in. > > Incidentally this also gets rid of a rather ugly > cross-dependence on the machine using an extern declaration. This sounds reasonable to me, although I know little about the driver. Varun, can you please comment? Acked-by: Stephen Warren