From: Steffen Klassert Subject: Re: crypto: skcipher - Use eseqiv even on UP machines Date: Fri, 25 Oct 2013 08:50:49 +0200 Message-ID: <20131025065049.GB31491@secunet.com> References: <20131024124149.GA10587@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, Linux Crypto Mailing List To: Herbert Xu Return-path: Received: from a.mx.secunet.com ([195.81.216.161]:59357 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab3JYGuz (ORCPT ); Fri, 25 Oct 2013 02:50:55 -0400 Content-Disposition: inline In-Reply-To: <20131024124149.GA10587@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Oct 24, 2013 at 08:41:49PM +0800, Herbert Xu wrote: > Hi: > > Previously we would use eseqiv on all async ciphers in all cases, > and sync ciphers if we have more than one CPU. This meant that > chainiv is only used in the case of sync ciphers on a UP machine. > > As chainiv may aid attackers by making the IV predictable, even > though this risk itself is small, the above usage pattern causes > it to further leak information about the host. > > This patch addresses these issues by using eseqiv even if we're > on a UP machine. > > Signed-off-by: Herbert Xu > That's fine by me. Acked-by: Steffen Klassert