From: Herbert Xu Subject: Re: [PATCH] crypto: omap-sham - Only release DMA channel if successfully requested Date: Thu, 5 Dec 2013 22:35:29 +0800 Message-ID: <20131205143529.GB1976@gondor.apana.org.au> References: <1384287147-19656-1-git-send-email-mgreer@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "David S. Miller" , Dan Carpenter , Joel Fernandes To: "Mark A. Greer" Return-path: Received: from ringil.hengli.com.au ([178.18.16.133]:41583 "EHLO ringil.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859Ab3LEOfj (ORCPT ); Thu, 5 Dec 2013 09:35:39 -0500 Content-Disposition: inline In-Reply-To: <1384287147-19656-1-git-send-email-mgreer@animalcreek.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Nov 12, 2013 at 01:12:27PM -0700, Mark A. Greer wrote: > In omap_sham_probe() and omap_sham_remove(), 'dd->dma_lch' > is released without checking to see if it was successfully > requested or not. This is a bug and was identified and > reported by Dan Carpenter here: > > http://www.spinics.net/lists/devicetree/msg11023.html > > Add code to only release 'dd->dma_lch' when its not NULL > (that is, when it was successfully requested). > > Reported-by: Dan Carpenter > CC: Joel Fernandes > Signed-off-by: Mark A. Greer Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt