From: Dan Carpenter Subject: [patch] crypto: remove a duplicate checks in __cbc_decrypt() Date: Thu, 13 Feb 2014 17:58:32 +0300 Message-ID: <20140213145832.GA11059@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org To: Herbert Xu , Jussi Kivilinna , Johannes Goetzfried Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:38811 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbaBMO7Q (ORCPT ); Thu, 13 Feb 2014 09:59:16 -0500 Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: We checked "nbytes < bsize" before so it can't happen here. Signed-off-by: Dan Carpenter --- This doesn't change how the code works, but maybe their is a bug in the original code. Please review? diff --git a/arch/x86/crypto/cast5_avx_glue.c b/arch/x86/crypto/cast5_avx_glue.c index e6a3700489b9..e57e20ab5e0b 100644 --- a/arch/x86/crypto/cast5_avx_glue.c +++ b/arch/x86/crypto/cast5_avx_glue.c @@ -203,9 +203,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -= 1; dst -= 1; } while (nbytes >= bsize * CAST5_PARALLEL_BLOCKS); - - if (nbytes < bsize) - goto done; } /* Handle leftovers */ diff --git a/arch/x86/crypto/blowfish_glue.c b/arch/x86/crypto/blowfish_glue.c index 50ec333b70e6..8af519ed73d1 100644 --- a/arch/x86/crypto/blowfish_glue.c +++ b/arch/x86/crypto/blowfish_glue.c @@ -223,9 +223,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -= 1; dst -= 1; } while (nbytes >= bsize * 4); - - if (nbytes < bsize) - goto done; } /* Handle leftovers */