From: Tomasz Figa Subject: Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module Date: Fri, 14 Feb 2014 11:54:50 +0100 Message-ID: <52FDF5FA.4000909@samsung.com> References: <1389095509-14357-6-git-send-email-ch.naveen@samsung.com> <1391750695-27447-1-git-send-email-ch.naveen@samsung.com> <52FD552E.8040008@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, vzapolskiy@gmail.com, herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com, cpgs@samsung.com To: Kukjin Kim , Naveen Krishna Chatradhi Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:43788 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbaBNKyz (ORCPT ); Fri, 14 Feb 2014 05:54:55 -0500 In-reply-to: <52FD552E.8040008@samsung.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Kukjin, On 14.02.2014 00:28, Kukjin Kim wrote: > On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: >> This patch adds the device tree node for SSS module >> found on Exynos5420 and Exynos5250 >> >> Signed-off-by: Naveen Krishna Chatradhi >> Reviewed-by: Tomasz Figa >> TO: >> CC: Kukjin Kim >> CC: >> --- >> changes since v5: >> 1. Added Reviewed-by: Tomasz Figa >> >> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ >> arch/arm/boot/dts/exynos5420.dtsi | 10 ++++++++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> b/arch/arm/boot/dts/exynos5250.dtsi >> index b7dec41..46b04e8 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -706,4 +706,12 @@ >> io-channel-ranges; >> status = "disabled"; >> }; >> + >> + sss@10830000 { >> + compatible = "samsung,exynos4210-secss"; >> + reg =<0x10830000 0x10000>; >> + interrupts =<0 112 0>; >> + clocks =<&clock 348>; >> + clock-names = "secss"; >> + }; >> }; >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >> b/arch/arm/boot/dts/exynos5420.dtsi >> index 8db792b..b503e96 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -652,4 +652,14 @@ >> clocks =<&clock 319>,<&clock 318>; >> clock-names = "tmu_apbif", "tmu_triminfo_apbif"; >> }; >> + >> + sss@10830000 { >> + compatible = "samsung,exynos4210-secss"; >> + reg =<0x10830000 0x10000>; >> + interrupts =<0 112 0>; >> + clocks =<&clock 471>; >> + clock-names = "secss"; >> + samsung,power-domain =<&g2d_pd>; >> + }; >> + >> }; > > Applied, thanks. > > BTW, I think the numbering is strange...maybe I missed something? > [PATCH 5/5], [PATCH 5/6 V2], [PATCH 6/8 V3] and this [PATCH 6/9 V6] I would wait with applying any patches from this series until they are acked by crypto subsystem maintainer and DT bindings by DT maintainers. I'd like Naveen to resend this series in separate thread, with proper message threading, so we can make sure that we are not missing anything. Naveen, please also add David S. Miller to Cc list, as he is also listed as crypto maintainer in MAINTAINERS file. Best regards, Tomasz