From: Herbert Xu Subject: Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending Date: Wed, 5 Mar 2014 09:59:53 +0800 Message-ID: <20140305015953.GA20702@gondor.apana.org.au> References: <1393957854-10961-1-git-send-email-joelf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, lokeshvutla@ti.com To: Joel Fernandes Return-path: Received: from ringil.hengli.com.au ([178.18.16.133]:46180 "EHLO ringil.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717AbaCEB7z (ORCPT ); Tue, 4 Mar 2014 20:59:55 -0500 Content-Disposition: inline In-Reply-To: <1393957854-10961-1-git-send-email-joelf@ti.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: > HIGHMEM pages may not be mapped so we must kmap them before accessing. > This resolves a random OOPs error that was showing up during OpenSSL SHA tests. > > Signed-off-by: Joel Fernandes > Cc: Herbert Xu > --- > v2 changes: > - don't check for HIGHMEM, kmap/kunmap do them anyway (Thanks Herbert). > > drivers/crypto/omap-sham.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c > index e45aaaf..207eac1 100644 > --- a/drivers/crypto/omap-sham.c > +++ b/drivers/crypto/omap-sham.c > @@ -636,11 +636,17 @@ static size_t omap_sham_append_buffer(struct omap_sham_reqctx *ctx, > static size_t omap_sham_append_sg(struct omap_sham_reqctx *ctx) > { > size_t count; > + const u8 *vaddr; > > while (ctx->sg) { > + vaddr = kmap(sg_page(ctx->sg)); Are you sure you can safely use kmap here as opposed to kmap_atomic? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt