From: Courtney Cavin Subject: Re: [PATCH 3/9] crypto: qce: Add dma and sg helpers Date: Mon, 7 Apr 2014 15:42:56 -0700 Message-ID: <20140407224256.GG17066@sonymobile.com> References: <1396541886-10966-1-git-send-email-svarbanov@mm-sol.com> <1396541886-10966-4-git-send-email-svarbanov@mm-sol.com> <20140403231525.GE17066@sonymobile.com> <533EAE81.6060109@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Herbert Xu , "David S. Miller" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" To: Stanimir Varbanov Return-path: Content-Disposition: inline In-Reply-To: <533EAE81.6060109@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Fri, Apr 04, 2014 at 03:07:13PM +0200, Stanimir Varbanov wrote: > >> diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h > >> new file mode 100644 > >> index 000000000000..932b02fd8f25 > >> --- /dev/null > >> +++ b/drivers/crypto/qce/dma.h > >> @@ -0,0 +1,57 @@ > >> +/* > >> + * Copyright (c) 2011-2014, The Linux Foundation. All rights reserved. > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 and > >> + * only version 2 as published by the Free Software Foundation. > >> + * > >> + * This program is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + */ > >> + > >> +#ifndef _DMA_H_ > >> +#define _DMA_H_ > >> + > >> +#define QCE_AUTHIV_REGS_CNT 16 > >> +#define QCE_AUTH_BYTECOUNT_REGS_CNT 4 > >> +#define QCE_CNTRIV_REGS_CNT 4 > >> + > >> +/* result dump format */ > >> +struct qce_result_dump { > >> + u32 auth_iv[QCE_AUTHIV_REGS_CNT]; > >> + u32 auth_byte_count[QCE_AUTH_BYTECOUNT_REGS_CNT]; > >> + u32 encr_cntr_iv[QCE_CNTRIV_REGS_CNT]; > >> + u32 status; > >> + u32 status2; > >> +}; > >> + > >> +#define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) > > > > QCE_BAM_BURST_SIZE is defined in common.h in 6/9. Either that file > > needs to be included from this one, or the definition needs to be moved. > > I decided to not include any files in driver private headers. Thus I > include the private header files in relevant c files in order. Actually, that is exactly what I was trying to indicate as undesirable. Please modify this so that each individual header file doesn't require you to include another file for usage. -Courtney