From: Sonic Zhang Subject: Re: [PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single Date: Mon, 14 Apr 2014 12:41:31 +0800 Message-ID: References: <1397119259-20638-1-git-send-email-sonic.adi@gmail.com> <1397119259-20638-2-git-send-email-sonic.adi@gmail.com> <201404101102.51947.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Herbert Xu , linux-crypto@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, Sonic Zhang To: Marek Vasut Return-path: Received: from mail-ob0-f176.google.com ([209.85.214.176]:54717 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbaDNElb (ORCPT ); Mon, 14 Apr 2014 00:41:31 -0400 Received: by mail-ob0-f176.google.com with SMTP id wp18so8454726obc.21 for ; Sun, 13 Apr 2014 21:41:31 -0700 (PDT) In-Reply-To: <201404101102.51947.marex@denx.de> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Herbert, Could you please review this patch? Thanks Sonic Zhang On Thu, Apr 10, 2014 at 5:02 PM, Marek Vasut wrote: > On Thursday, April 10, 2014 at 10:40:59 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> - The 4-byte sg_mid_buf is located in the middle of the coherence memory >> sg_cpu. Don't call dma_map_single to get its physical address. Get the its >> base physical address from the physical address of sg_cpu instead. >> - Should set up the dma descriptor data after the 4-byte sg_mid_buf is >> filled in completely from next sg buffer. >> - memory copy from sg buffer should be done via virtual address. >> - Remove unused reference to blackfin header >> >> Signed-off-by: Sonic Zhang > > I don't see any obvious problems, > > Reviewed-by: Marek Vasut > > Best regards, > Marek Vasut