From: Joachim Eastwood Subject: Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync Date: Tue, 15 Apr 2014 19:06:25 +0200 Message-ID: References: <534D61DF.9090203@ti.com> <1397581111-21148-1-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Joel Fernandes , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, balbi@ti.com To: Nishanth Menon Return-path: Received: from mail-lb0-f175.google.com ([209.85.217.175]:50576 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbaDORG1 (ORCPT ); Tue, 15 Apr 2014 13:06:27 -0400 In-Reply-To: <1397581111-21148-1-git-send-email-nm@ti.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 15 April 2014 18:58, Nishanth Menon wrote: > pm_runtime_get_sync may not always succeed depending on SoC involved. > So handle the error appropriately ensuring usage_count is accurate in > case of failure. > > Signed-off-by: Nishanth Menon > --- > V2: > - review fixes, print function names in error log as well. > > V1: https://patchwork.kernel.org/patch/3993861/ > drivers/crypto/omap-des.c | 26 +++++++++++++++++++++++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > Fixes the runtime warning from omap_l3_noc when omap-des is built-in on my VAR-SOM-OM44 (OMAP4460) board. Tested-by: Joachim Eastwood regards Joachim Eastwood