From: Joel Fernandes Subject: Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync Date: Tue, 15 Apr 2014 12:51:43 -0500 Message-ID: <534D71AF.2090808@ti.com> References: <534D61DF.9090203@ti.com> <1397581111-21148-1-git-send-email-nm@ti.com> <534D69D0.207@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Herbert Xu , "David S. Miller" , , "linux-kernel@vger.kernel.org" , , To: Nishanth Menon , Joachim Eastwood Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:38758 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbaDORvt (ORCPT ); Tue, 15 Apr 2014 13:51:49 -0400 In-Reply-To: <534D69D0.207@ti.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 04/15/2014 12:18 PM, Nishanth Menon wrote: > On 04/15/2014 12:06 PM, Joachim Eastwood wrote: >> On 15 April 2014 18:58, Nishanth Menon wrote: >>> pm_runtime_get_sync may not always succeed depending on SoC involved. >>> So handle the error appropriately ensuring usage_count is accurate in >>> case of failure. >>> >>> Signed-off-by: Nishanth Menon >>> --- >>> V2: >>> - review fixes, print function names in error log as well. >>> >>> V1: https://patchwork.kernel.org/patch/3993861/ >>> drivers/crypto/omap-des.c | 26 +++++++++++++++++++++++--- >>> 1 file changed, 23 insertions(+), 3 deletions(-) >>> >> >> Fixes the runtime warning from omap_l3_noc when omap-des is built-in >> on my VAR-SOM-OM44 (OMAP4460) board. >> >> Tested-by: Joachim Eastwood > > Thanks Joachim. Looks like in my hurry, I missed proper > acknowledgement of your report. adding the following for patchworks to > pickup. > > Reported-by: Joachim Eastwood > Acked-by: Joel Fernandes Regards, -Joel