From: "H. Peter Anvin" Subject: Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions Date: Thu, 17 Apr 2014 21:49:56 -0700 Message-ID: <5350AEF4.9060905@zytor.com> References: <1397665190-12491-1-git-send-email-nasa4836@gmail.com> <201404171728.41994.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: herbert@gondor.apana.org.au, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Marek Vasut , Jianyu Zhan Return-path: Received: from terminus.zytor.com ([198.137.202.10]:34729 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbaDREuf (ORCPT ); Fri, 18 Apr 2014 00:50:35 -0400 In-Reply-To: <201404171728.41994.marex@denx.de> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 04/17/2014 08:28 AM, Marek Vasut wrote: > On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote: >> Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts >> asmlinkage to externally_visible, this causes compilation warnings: >> >> arch/x86/crypto/sha256_ssse3_glue.c:56:1: >> warning: =E2=80=98externally_visible=E2=80=99 attribute have eff= ect only on public >> objects [-Wattributes] >> >> static asmlinkage void (*sha256_transform_asm)(const char *, u32= *, >> u64); ^ >> >> arch/x86/crypto/sha512_ssse3_glue.c:55:1: >> warning: =E2=80=98externally_visible=E2=80=99 attribute have eff= ect only on public >> objects [-Wattributes] static asmlinkage void >> (*sha512_transform_asm)(const char *, u64 *, ^ >> >> Drop asmlinkage here to avoid such warnings. >> >> Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage fro= m >> static functions") >> >> Signed-off-by: Jianyu Zhan >=20 > Makes sense, please add my humble >=20 > Reviewed-by: Marek Vasut >=20 It doesn't make sense, sorry. The right thing to drop here is not "asmlinkage", it is "static": this is an external declaration. -hpa