From: Vakul Garg Subject: RE: [PATCH] crypto: caam - Fix key inlining in AEAD shared descriptors Date: Sat, 3 May 2014 11:44:39 +0000 Message-ID: <72e203ad27a64b66b1b876e7b9978e5c@BL2PR03MB162.namprd03.prod.outlook.com> References: <1398612374-1746-1-git-send-email-vakul@freescale.com> <20140502191008.db1408c0735f14ed1a0bdb8b@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-crypto@vger.kernel.org" , "herbert@gondor.apana.org.au" , "Horia.Geanta@freescale.com" , Ruchika Gupta , "alexandru.porosanu@freescale.com" To: Kim Phillips Return-path: Received: from mail-bn1lp0141.outbound.protection.outlook.com ([207.46.163.141]:3425 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751012AbaECLon convert rfc822-to-8bit (ORCPT ); Sat, 3 May 2014 07:44:43 -0400 In-Reply-To: <20140502191008.db1408c0735f14ed1a0bdb8b@freescale.com> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Kim Phillips [mailto:kim.phillips@freescale.com] > Sent: Saturday, May 03, 2014 5:40 AM > To: Garg Vakul-B16394 > Cc: linux-crypto@vger.kernel.org; herbert@gondor.apana.org.au; Geanta > Neag Horia Ioan-B05471; Gupta Ruchika-R66431; Porosanu Alexandru-B06830 > Subject: Re: [PATCH] crypto: caam - Fix key inlining in AEAD shared > descriptors > > On Sun, 27 Apr 2014 11:26:14 -0400 > Vakul Garg wrote: > > > The variable 'keys_fit_inline' is initialised correctly to avoid using > > its stale value while creating shared descriptor for decryption and > > given-iv-encryption. > > you mean givencrypt? That's "generate an IV and encrypt". I will modify it and submit next patch version. > > > @@ -220,6 +220,8 @@ static int aead_null_set_sh_desc(struct crypto_aead > *aead) > > if (DESC_AEAD_NULL_ENC_LEN + DESC_JOB_IO_LEN + > > ctx->split_key_pad_len <= CAAM_DESC_BYTES_MAX) > > keys_fit_inline = true; > > + else > > + keys_fit_inline = false; > > Can we do the easier to read: > > keys_fit_inline = false; > if (DESC_AEAD_NULL_ENC_LEN + DESC_JOB_IO_LEN + > ctx->split_key_pad_len <= CAAM_DESC_BYTES_MAX) > keys_fit_inline = true; > > ? Why pre-init a variable with default value when it could be overwritten? I think that the form I submitted is equally easy to read. > > Thanks. > > Kim