From: Marek Vasut Subject: Re: [PATCH v2] crypto: caam - fix memleak in caam_jr module Date: Wed, 9 Jul 2014 22:31:47 +0200 Message-ID: <201407092231.47266.marex@denx.de> References: <75b67e0fc305452fb5075e5bee5fff9c@BL2PR03MB162.namprd03.prod.outlook.com> <1404389270-19588-1-git-send-email-cristian.stoica@freescale.com> <20140703175406.548b5db8610cf286aa5e2cc9@freescale.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Cristian Stoica , Herbert Xu , linux-crypto@vger.kernel.org, "David S. Miller" To: Kim Phillips Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:37766 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbaGIVIr (ORCPT ); Wed, 9 Jul 2014 17:08:47 -0400 In-Reply-To: <20140703175406.548b5db8610cf286aa5e2cc9@freescale.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Friday, July 04, 2014 at 12:54:06 AM, Kim Phillips wrote: > On Thu, 3 Jul 2014 15:07:50 +0300 > > Cristian Stoica wrote: > > This patch fixes a memory leak that appears when caam_jr module is > > unloaded. > > > > Cc: # 3.13+ > > Signed-off-by: Cristian Stoica > > --- > > > > drivers/crypto/caam/jr.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c > > index 1d80bd3..e0b91fc 100644 > > --- a/drivers/crypto/caam/jr.c > > +++ b/drivers/crypto/caam/jr.c > > @@ -453,7 +453,7 @@ static int caam_jr_probe(struct platform_device > > *pdev) > > > > int error; > > > > jrdev = &pdev->dev; > > > > - jrpriv = kmalloc(sizeof(struct caam_drv_private_jr), > > + jrpriv = devm_kzalloc(jrdev, sizeof(struct caam_drv_private_jr), > > > > GFP_KERNEL); > > alignment. Also, why are we replacing a _m_alloc with a _z_alloc? I am fine with replacing kmalloc with kzalloc in this context. Best regards, Marek Vasut