From: Chen Gang Subject: Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS_IOMEM Date: Mon, 14 Jul 2014 20:12:31 +0800 Message-ID: <53C3C92F.8010504@gmail.com> References: <53C1F692.4000105@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , Liqin Chen , Lennox Wu To: herbert@gondor.apana.org.au Return-path: Received: from mail-pd0-f177.google.com ([209.85.192.177]:58999 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbaGNMMf (ORCPT ); Mon, 14 Jul 2014 08:12:35 -0400 In-Reply-To: <53C1F692.4000105@gmail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hello all: This patch is obsoleted according to the other discussion thread about IOMEM and COMPILE_TEST. I shall fix it, and maybe not need touch drivers/crypto again, so maybe not need send patch v2 for it. Thanks. On 07/13/2014 11:01 AM, Chen Gang wrote: > 'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them. > > The related error (with allmodconfig under score): > > MODPOST 1365 modules > ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined! > ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined! > ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined! > ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined! > ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined! > > Signed-off-by: Chen Gang > --- > drivers/crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index 5ef9ec9..2fb0fdf 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -422,7 +422,7 @@ source "drivers/crypto/qat/Kconfig" > > config CRYPTO_DEV_QCE > tristate "Qualcomm crypto engine accelerator" > - depends on ARCH_QCOM || COMPILE_TEST > + depends on (ARCH_QCOM || COMPILE_TEST) && HAS_DMA && HAS_IOMEM > select CRYPTO_AES > select CRYPTO_DES > select CRYPTO_ECB > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed