From: Herbert Xu Subject: Re: [PATCH 2/2] crypto: sahara - add support for SHA1/256 Date: Fri, 29 Aug 2014 22:02:17 +0800 Message-ID: <20140829140217.GA10202@gondor.apana.org.au> References: <1408367619-3436-1-git-send-email-s.trumtrar@pengutronix.de> <1408367619-3436-2-git-send-email-s.trumtrar@pengutronix.de> <20140829134442.GA9971@gondor.apana.org.au> <20140829135855.GA13580@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , linux-crypto@vger.kernel.org To: Steffen Trumtrar Return-path: Received: from helcar.apana.org.au ([209.40.204.226]:55414 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752642AbaH2OCX (ORCPT ); Fri, 29 Aug 2014 10:02:23 -0400 Content-Disposition: inline In-Reply-To: <20140829135855.GA13580@pengutronix.de> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Aug 29, 2014 at 03:58:55PM +0200, Steffen Trumtrar wrote: > > On Fri, Aug 29, 2014 at 09:44:42PM +0800, Herbert Xu wrote: > > On Mon, Aug 18, 2014 at 03:13:39PM +0200, Steffen Trumtrar wrote: > > > > > > +struct sahara_sha_reqctx { > > > + unsigned int mode; > > > + unsigned int digest_size; > > > + unsigned int context_size; > > > + u8 buf[SAHARA_MAX_SHA_BLOCK_SIZE]; > > > + unsigned int buf_cnt; > > > + unsigned int hash_rem; > > > + struct sg_table data_sg; > > > + struct scatterlist buf_sg; > > > + unsigned int sg_in_idx; > > > + unsigned int result_idx; > > > +}; > > > > So where is the hash state stored? > > > > The hash state is stored in the context_base variable in sahara_dev. > Freescale calls it context in their driver (the only source of information > I have to develop a GPL driver). > To simplify the driver I allocated the context also as dma_alloc_coherent, > same as the key_base for AES. Hmm that's a bit of a problem because our API requires the hash state to be stored in the request as otherwise a new request belonging to a different hash computation will cause corruption. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt