From: Behan Webster Subject: Re: [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c Date: Mon, 15 Sep 2014 07:25:16 -0700 Message-ID: <5416F6CC.3050203@converseincode.com> References: <1410766234-1634-1-git-send-email-behanw@converseincode.com> <1410766234-1634-12-git-send-email-behanw@converseincode.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alasdair G Kergon , Chris Mason , David Miller , "dm-devel@redhat.com" , Fabian Frederick , Herbert Xu , Josef Bacik , Mike Snitzer , tadeusz.struk@intel.com, Andrew Morton , Bruce Allan , Dmitry Kasatkin , James Morris , john.griffin@intel.com, linux-btrfs , Linux Crypto Mailing List , linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, Linux Kernel Mailing List , "linux-raid@vger.kernel.org" , LSM List , Neil Brown , qat-lin To: Linus Torvalds Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 09/15/14 07:21, Linus Torvalds wrote: > On Mon, Sep 15, 2014 at 12:30 AM, wrote: >> From: Behan Webster >> >> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 >> compliant equivalent. This patch allocates the appropriate amount of memory >> using a char array using the SHASH_DESC_ON_STACK macro. > You only made the first case use SHASH_DESC_ON_STACK, the two other > cases you left in the ugly format. Was that just an oversight, or was > there some reason for it? > Oversight. Will Fix. Behan -- Behan Webster behanw@converseincode.com