From: Herbert Xu Subject: Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator Date: Fri, 31 Oct 2014 16:18:03 +0800 Message-ID: <20141031081803.GA8012@gondor.apana.org.au> References: <1413728182-13569-1-git-send-email-clabbe.montjoie@gmail.com> <1413728182-13569-5-git-send-email-clabbe.montjoie@gmail.com> <20141021191149.GQ21108@lukather> <544A9FEA.6020304@gmail.com> <20141030171933.GR21251@lukather> <20141031072030.GA7563@gondor.apana.org.au> <20141031081323.GS21251@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Corentin LABBE , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, crope-X3B1VOXEql0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: Maxime Ripard Return-path: Content-Disposition: inline In-Reply-To: <20141031081323.GS21251@lukather> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Fri, Oct 31, 2014 at 09:13:23AM +0100, Maxime Ripard wrote: > > I don't understand here. Why would other drivers *not* being affected? > > If the scatter list passed by AF_ALG can be in highmem, I guess it's > the case for every driver out there. Almost every kernel code I've > seen so far makes the assumption that the memory it has is mapped and > accessible. > > Somehow, it's the driver's fault now, and not the part of kernel that > actually does the allocation? If you are implementing a crypto driver that is meant to handle requests from the crypto API then yes you need to handle highmem. As I said if enough drivers are unable to address highmem and require copying/software fallbacks then we could provide this through the API and the driver would then only need to declare its lack of highmem support or use a helper. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html