From: Mathias Krause Subject: Re: [PATCH] crypto: prefix module autoloading with "crypto-" Date: Mon, 17 Nov 2014 19:38:21 +0100 Message-ID: References: <20141114213459.GA3832@www.outflux.net> <20141117150926.GA1968@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" To: Herbert Xu , Kees Cook Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:59305 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbaKQSiX convert rfc822-to-8bit (ORCPT ); Mon, 17 Nov 2014 13:38:23 -0500 In-Reply-To: <20141117150926.GA1968@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 17 November 2014 16:09, Herbert Xu wro= te: > On Fri, Nov 14, 2014 at 01:34:59PM -0800, Kees Cook wrote: >> This prefixes all crypto module loading with "crypto-" so we never r= un >> the risk of exposing module auto-loading to userspace via a crypto A= PI, >> as demonstrated by Mathias Krause: >> >> https://lkml.org/lkml/2013/3/4/70 >> >> Signed-off-by: Kees Cook > > Sorry but this doesn't build for me: > > CC [M] drivers/crypto/qat/qat_common/adf_ctl_drv.o > drivers/crypto/qat/qat_common/adf_ctl_drv.c:490:21: error: expected d= eclaration specifiers or =E2=80=98...=E2=80=99 before string constant > make[3]: *** [drivers/crypto/qat/qat_common/adf_ctl_drv.o] Error 1 > make[2]: *** [drivers/crypto/qat/qat_common] Error 2 > make[1]: *** [drivers/crypto/qat] Error 2 > make[1]: *** Waiting for unfinished jobs.... Looks like drivers/crypto/qat/qat_common/adf_ctl_drv.c is missing '#include '. Mathias