From: Steffen Klassert Subject: Re: crypto: user - Allow get request with empty driver name Date: Thu, 20 Nov 2014 09:04:06 +0100 Message-ID: <20141120080406.GV6390@secunet.com> References: <5365136.g8vbXlhRyC@tachyon.chronox.de> <1886827.KUDIsNtfuk@tachyon.chronox.de> <20141120041824.GA28612@gondor.apana.org.au> <3538055.XH2t7HNEVj@tachyon.chronox.de> <20141120044650.GA28691@gondor.apana.org.au> <20141120071141.GS6390@secunet.com> <20141120074526.GB29544@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Stephan Mueller , Daniel Borkmann , , LKML , , ABI/API To: Herbert Xu Return-path: Content-Disposition: inline In-Reply-To: <20141120074526.GB29544-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Thu, Nov 20, 2014 at 03:45:26PM +0800, Herbert Xu wrote: > On Thu, Nov 20, 2014 at 08:11:42AM +0100, Steffen Klassert wrote: > > > > I think this is not sufficient, crypto_alg_match() will now return the first > > algorithm in crypto_alg_list that matches cra_name. We would need to extend > > crypto_alg_match() to return the algorithm with the highest priority in that > > case. > > It doesn't really matter because all implementations must provide > exactly the same set of parameters for a given algorithm so it's > good enough for what Stephan wants to do. Ok, I see. > But yes an interface to grab the highest priority algorithm would > be useful too so patches are welcome :) Should be not too hard to return the highest priority algorithm instead of the first match with the existing interface, I'll see what I can do.