From: Herbert Xu Subject: Re: [PATCH v5 5/8] crypto: AF_ALG: add user space interface for RNG Date: Mon, 22 Dec 2014 22:27:30 +1100 Message-ID: <20141222112730.GB19532@gondor.apana.org.au> References: <56740432.V2v4gLHrzS@tachyon.chronox.de> <3380968.kTQNpvjKFa@tachyon.chronox.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Borkmann , 'Quentin Gouchet' , 'LKML' , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephan Mueller Return-path: Content-Disposition: inline In-Reply-To: <3380968.kTQNpvjKFa-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Sun, Dec 07, 2014 at 11:23:48PM +0100, Stephan Mueller wrote: > Allow user space to seed / reset the RNG via a setsockopt. > > This patch reuses alg_setkey to copy data into the kernel. The > alg_setkey is now used for two mechanisms: setkey and seeding. > The function is extended by the providing the function pointer > to the function handling the copied data. > > As the alg_setkey is now usable for more than just setkey, it is renamed > to alg_setop. Just call it setkey, there is no harm in treating the seed as a key is there? In fact we should have done this from the very start. crypto_rng_reset should be renamed crypto_rng_setkey. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt