From: Asaf Vertz Subject: [PATCH] crypto: omap-des: fix BUG_ON condition Date: Mon, 5 Jan 2015 10:23:10 +0200 Message-ID: <20150105082310.GA19423@ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: herbert@gondor.apana.org.au, davem@davemloft.net Return-path: Received: from mail-wi0-f176.google.com ([209.85.212.176]:39283 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbbAEIbb (ORCPT ); Mon, 5 Jan 2015 03:31:31 -0500 Received: by mail-wi0-f176.google.com with SMTP id ex7so2759161wid.9 for ; Mon, 05 Jan 2015 00:31:29 -0800 (PST) Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: dd->total is unsigned so it won't do any good to check for negative value after subtracting instead of that we should check if the subtracted value is bigger than him This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Asaf Vertz --- drivers/crypto/omap-des.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index e350f5b..0b8dcf5 100644 --- a/drivers/crypto/omap-des.c +++ b/drivers/crypto/omap-des.c @@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id) } } - dd->total -= DES_BLOCK_SIZE; + BUG_ON(dd->total < DES_BLOCK_SIZE); - BUG_ON(dd->total < 0); + dd->total -= DES_BLOCK_SIZE; /* Clear IRQ status */ status &= ~DES_REG_IRQ_DATA_OUT; -- 1.7.0.4