From: Cristian Stoica Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings Date: Wed, 4 Mar 2015 10:48:55 +0200 Message-ID: <54F6C6F7.6020400@freescale.com> References: <1425365453-19358-1-git-send-email-yanjiang.jin@windriver.com> <1425365453-19358-2-git-send-email-yanjiang.jin@windriver.com> <20150303125953.8585904680288a9734566b42@freescale.com> <54F66EA3.7080506@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , , , , , , , To: yjin , Kim Phillips Return-path: Received: from mail-by2on0101.outbound.protection.outlook.com ([207.46.100.101]:6538 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932632AbbCDJWH (ORCPT ); Wed, 4 Mar 2015 04:22:07 -0500 In-Reply-To: <54F66EA3.7080506@windriver.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: >=20 > On 2015=E5=B9=B403=E6=9C=8804=E6=97=A5 02:59, Kim Phillips wrote: >> On Tue, 3 Mar 2015 14:50:51 +0800 >> wrote: >> >>> This commit is to avoid the below warnings: >>> >>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: >>> 'dma_map_sg_chained' defined but not used [-Wunused-function] >>> static int dma_map_sg_chained(struct device *dev, struct >>> scatterlist *sg, [...] >=20 > We can find an example in Freescale SDK 1.6: > caampkc.c includes pkc_desc.h, pkc_desc.h includes sg_sw_sec4.h, but > caampkc.c doesn't call those functions. This one was fixed in sdk-1.7 with the following patch: diff --git a/drivers/crypto/caam/pkc_desc.h b/drivers/crypto/caam/pkc_d= esc.h index f73ad07..03013c2 100644 --- a/drivers/crypto/caam/pkc_desc.h +++ b/drivers/crypto/caam/pkc_desc.h @@ -20,7 +20,6 @@ #include "desc_constr.h" #include "jr.h" #include "error.h" -#include "sg_sw_sec4.h" #include #include "pdb.h" Cristian S.