From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 00/10] omap3 crypto fixes
Date: Fri, 6 Mar 2015 11:18:45 -0800
Message-ID: <20150306191845.GC13520@atomide.com>
References: <1424958600-18881-1-git-send-email-pali.rohar@gmail.com>
 <20150306183631.GA13520@atomide.com>
 <201503062016.05608@pali>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson <bcousson@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Paul Walmsley <paul@pwsan.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	Pavel Machek <pavel@ucw.cz>, Nishanth Menon <nm@ti.com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Sebastian Reichel <sre@kernel.org>
To: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <201503062016.05608@pali>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-crypto.vger.kernel.org

* Pali Roh=C3=A1r <pali.rohar@gmail.com> [150306 11:16]:
> On Friday 06 March 2015 19:36:32 Tony Lindgren wrote:
> > * Pali Roh=C3=A1r <pali.rohar@gmail.com> [150226 05:54]:
> > > This patch series fix crypto support for omap3 devices which
> > > use DT.
> > >=20
> > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > > still disabled for N900.
> > >=20
> > > Pali Roh=C3=A1r (10):
> > >   ARM: OMAP2+: Return correct error values from device and
> > >   hwmod ARM: OMAP3: Fix crypto support for HS devices
> > >   crypto: omap-sham: Add support for omap3 devices
> > >   crypto: omap-sham: Check for return value from
> > >   pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12
> > >   ARM: dts: omap3: Add missing dmas for crypto
> > >   ARM: dts: n9/n950: Enable omap crypto support
> > >   ARM: dts: n900: Enable omap sham and include directly
> > >   omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly
> > >   omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and
> > >   omap36xx-hs.dtsi
> > > =20
> > >  arch/arm/boot/dts/omap3-n900.dts           |   16 +++++-
> > >  arch/arm/boot/dts/omap3-n950-n9.dtsi       |    2 +-
> > >  arch/arm/boot/dts/omap3-tao3530.dtsi       |   11 +++-
> > >  arch/arm/boot/dts/omap3.dtsi               |    4 ++
> > >  arch/arm/boot/dts/omap34xx-hs.dtsi         |   16 ------
> > >  arch/arm/boot/dts/omap36xx-hs.dtsi         |   16 ------
> > >  arch/arm/mach-omap2/omap_device.c          |   30
> > >  ++++++----- arch/arm/mach-omap2/omap_hwmod.c           | =20
> > >  10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   79
> > >  +++++++++++++++++++++++----- drivers/crypto/omap-sham.c  =20
> > >               |   13 ++++- 10 files changed, 131
> > >  insertions(+), 66 deletions(-) delete mode 100644
> > >  arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644
> > >  arch/arm/boot/dts/omap36xx-hs.dtsi
> >=20
> > Are there any fixes in this series that should go into
> > v4.0-rc series, or can it all wait for v4.1?
> >=20
> > Regards,
> >=20
> > Tony
>=20
> I do not know which patches are you sending to 4.0-rc series, but=20
> omap crypto is totally broken in linus tree for both GP & HS=20
> omap3 devices when DT booting is used. This patch series fix that=20
> problem.

OK so the whole series is needed then. It seems too intrusive for
the v4.0-rc series unless this fixes a regression with some earlier
commit.

Regards,

Tony