From: Maxime Ripard Subject: Re: [PATCH v8 2/4] ARM: sunxi: dt: Add DT bindings documentation for SUNXI Security System Date: Thu, 23 Apr 2015 21:35:38 +0200 Message-ID: <20150423193538.GF28007@lukather> References: <1429771523-2936-1-git-send-email-clabbe.montjoie@gmail.com> <1429771523-2936-3-git-send-email-clabbe.montjoie@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XIiC+We3v3zHqZ6Z" Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: LABBE Corentin Return-path: Content-Disposition: inline In-Reply-To: <1429771523-2936-3-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org --XIiC+We3v3zHqZ6Z Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, Apr 23, 2015 at 08:45:21AM +0200, LABBE Corentin wrote: > This patch adds documentation for Device-Tree bindings for the Security System cryptographic accelerator driver. > > Signed-off-by: LABBE Corentin > --- > Documentation/devicetree/bindings/crypto/sunxi-ss.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/sunxi-ss.txt > > diff --git a/Documentation/devicetree/bindings/crypto/sunxi-ss.txt b/Documentation/devicetree/bindings/crypto/sunxi-ss.txt > new file mode 100644 > index 0000000..a566803 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/sunxi-ss.txt > @@ -0,0 +1,9 @@ > +* Allwinner Security System found on A20 SoC > + > +Required properties: > +- compatible : Should be "allwinner,sun7i-a20-crypto". > +- reg: Should contain the Security System register location and length. > +- interrupts: Should contain the IRQ line for the Security System. > +- clocks : A phandle to the functional clock node of the Security System module You actually need two clock references, not just a single phandle. > +- clock-names : Name of the functional clock, should be "ahb" and "mod". And we usually have an example after too. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --XIiC+We3v3zHqZ6Z--